add feature flag for including breaking changes regardless of app version - #48406
Merged
Conversation
clintjedwards
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the features to include in a build are determined by the version set in
Cargo.toml. For example, setting it to 2.0.0 causes v2 features to be included. However, we want to move to a version management process whereby:Cargo.tomlinmainis set to the most recently released version. Currently that's 1.41.0.maincan potentially include upcoming breaking changes. For example, if the current version is 1.41.0, and 2.0.0 is imminent, we want a way to include the v2 features by default onmainwithout updating the version yet.The latter behavior feels a little strange but it is expected with this style of process. Historically we've used a
-devsuffix to disambiguatemainbuilds vs release builds but this is not idiomatic.This PR introduces a
breaking-changesfeature flag that includes everything, disabled by default. If disabled, only the features appropriate for the version set inCargo.tomlare included, so no change in behavior. However, when a major version change is imminent, we can choose to explicitly enablebreaking-changesinCargo.tomlsuch that buildingmaingets everything.This PR also sets the version in
Cargo.tomlto that of the most recent release. This means v2 features will no longer be included by default when buildingmain. Notably, there is no-devsuffix.