Skip to content

add feature flag for including breaking changes regardless of app version - #48406

Merged
jkarneges merged 2 commits into
mainfrom
jkarneges/compat-version
Aug 27, 2026
Merged

add feature flag for including breaking changes regardless of app version#48406
jkarneges merged 2 commits into
mainfrom
jkarneges/compat-version

Conversation

@jkarneges

@jkarneges jkarneges commented Aug 27, 2026

Copy link
Copy Markdown
Member

Currently, the features to include in a build are determined by the version set in Cargo.toml. For example, setting it to 2.0.0 causes v2 features to be included. However, we want to move to a version management process whereby:

  • The version in Cargo.toml in main is set to the most recently released version. Currently that's 1.41.0.
  • Building from main can potentially include upcoming breaking changes. For example, if the current version is 1.41.0, and 2.0.0 is imminent, we want a way to include the v2 features by default on main without updating the version yet.

The latter behavior feels a little strange but it is expected with this style of process. Historically we've used a -dev suffix to disambiguate main builds vs release builds but this is not idiomatic.

This PR introduces a breaking-changes feature flag that includes everything, disabled by default. If disabled, only the features appropriate for the version set in Cargo.toml are included, so no change in behavior. However, when a major version change is imminent, we can choose to explicitly enable breaking-changes in Cargo.toml such that building main gets everything.

This PR also sets the version in Cargo.toml to that of the most recent release. This means v2 features will no longer be included by default when building main. Notably, there is no -dev suffix.

@jkarneges jkarneges changed the title use COMPAT_VERSION instead of app version to limit what is included use app version to limit what is included and add feature flag to override it Aug 27, 2026
@jkarneges jkarneges changed the title use app version to limit what is included and add feature flag to override it limit what is included based on app version, with flag to override Aug 27, 2026
@jkarneges jkarneges changed the title limit what is included based on app version, with flag to override add feature flag to include breaking changes regardless of app version Aug 27, 2026
@jkarneges jkarneges changed the title add feature flag to include breaking changes regardless of app version add feature flag for including breaking changes regardless of app version Aug 27, 2026
@jkarneges
jkarneges merged commit f718c9c into main Aug 27, 2026
19 checks passed
@jkarneges
jkarneges deleted the jkarneges/compat-version branch August 27, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants