Skip to content

Added a Llama Picture and Llama Facts Command #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zycrasion wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added a Llama Picture and Llama Facts Command #196

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9636995
Llama Picture Command
Zycrasion May 17, 2023
c63d874
fixed caching issue
Zycrasion May 17, 2023
d25a5ef
now sends the direct links
Zycrasion May 17, 2023
3d44d46
llama fax
Zycrasion May 17, 2023
d80bd0c
Fixed bug and added error checing
Zycrasion May 17, 2023
be5910a
Removed unneeded comments
Zycrasion May 19, 2023
daa6f52
Open Brackets On Same Line as keyword
Zycrasion May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions lib/Synergy/Reactor/CatPic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,65 @@ sub _build_reactions ($self, @) {
return $reactions;
}

# Copied cat_pic code
# Because there was no documentation
# Works on terminal, dunno if slack wil be able to display it as an image

@notbrokenjemma notbrokenjemma May 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cat pic works by assuming slack will recognise the url and fetch the target for display, so assuming what is returned is a url it should work just fine

# Tried to test it on local slack, but the documentation was pretty bad with the config files
responder llama_pic => {
exclusive => 1, # No idea what this is.
targeted => 1, # Or this

@notbrokenjemma notbrokenjemma May 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exclusive is a means to prevent a string being matched by multiple responders, targeted is to do with if you need to target the bot with @botName or PM etc. Someone who has worked on synergy before could answer those questions, but copying what is in catpic is fine here.

help_titles => [ 'llama pic' ],
help => '*llama pic*: get a picture of a llama',
matcher => sub ($text, @) {
return unless $text =~ /\Allama\spic\z/i;
return [];
},
}, sub ($self, $event) {
$event->mark_handled;

my $http_future = $self->hub->http_client->GET(
"https://llama-as-a-service.vercel.app/llama_url"

@notbrokenjemma notbrokenjemma May 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you create this API just for this task? cool!

);

return $http_future->on_done(sub($res)
{

@notbrokenjemma notbrokenjemma May 17, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some error handling, what happens if we don't get a 200 from the remote api call? What happens if the remote API stops returning a single URL to a picture and starts returning a large html page?

if ($res->code == 200)
{

@notbrokenjemma notbrokenjemma May 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit pick, the new code uses a different brace style to the rest of the code.
opening brace on the same line as the related keyword, one space before brace

$event->reply($res->content);
return;
}
$event->reply("Error while retrieving llama pictures!")
});
};

responder llama_fax => {
exclusive => 1, # No idea what this is.
targeted => 1, # Or this
help_titles => [ 'llama fax' ],
help => '*llama fax*: get a fact about a llama',
matcher => sub ($text, @) {
return unless $text =~ /\Allama\s(facts?|fax)\z/i;
return [];
},
}, sub ($self, $event) {
$event->mark_handled;

my $http_future = $self->hub->http_client->GET(
"https://llama-as-a-service.vercel.app/llama_fax"
);

return $http_future->on_done(sub($res)
{
if ($res->code == 200)
{
$event->reply($res->content);
return;
}

$event->reply("Error while retrieving llama fax!")
});
};

responder cat_pic => {
exclusive => 1,
targeted => 1,
Expand Down