additional checks for an archive.pooch_hash file in lieu of the archive - #549
Open
J-Wall wants to merge 1 commit into
Open
additional checks for an archive.pooch_hash file in lieu of the archive#549J-Wall wants to merge 1 commit into
J-Wall wants to merge 1 commit into
Conversation
…actual file being there, along with delete_after_extraction option to processors
J-Wall
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added checks in
pooch.core.download_actionfor a file namedf"{fname}.pooch_hash"which, if present, allows the archive file itself to be deleted (without triggering subsequent re-downloads). The.pooch_hashfiles contain:On the first line, separated by a space
" ":On subsequent lines, also separated by a space, with one line per extracted member of the archive:
Why
I added this because I want to use pooch to download large archives (GB range), but I'm only interested in a processed extract of those archives (100MB range), and I would rather not waste disk space with holding onto an archive file I don't need.
I have tried to design the functionality to be in the spirit of the existing pooch code. e.g. enabling integrity checking of processed files via storing their hash in the placeholder file.
Relevant issues/PRs:
Fixes #158