Skip to content

fix: update vite to 5.5.0+ to patch Rollup path traversal vulnerability #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fatihtokus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update vite to 5.5.0+ to patch Rollup path traversal vulnerability #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/frontend-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"prettier": "3.2.5",
"raw-loader": "^4.0.2",
"typescript": "^5.2.2",
"vite": "^5.4.14",
"vite": "^5.5.0",

@qodo-code-review qodo-code-review Bot Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Lockfile still pins old vite 🐞 Bug ⛨ Security

src/frontend-app/package.json bumps Vite to ^5.5.0, but src/frontend-app/package-lock.json still
resolves Vite 5.4.14 (and Rollup 4.22.4), so installs that honor the lockfile will continue using
the pre-upgrade toolchain. This undermines the PR’s stated goal (shipping the patched Rollup) and
can also break strict installs due to package.json/package-lock.json divergence.
Agent Prompt 
### Issue description
`src/frontend-app/package.json` was updated to require `vite: ^5.5.0`, but the committed `src/frontend-app/package-lock.json` still pins `vite@5.4.14` (and its `rollup@4.22.4`). As a result, any install that uses the lockfile will not actually consume the upgraded/patched dependency chain.

### Issue Context
This PR’s intent is to patch a Rollup path traversal vulnerability by upgrading Vite/Rollup. That goal is not achieved if the lockfile continues to resolve the old versions.

### Fix
- From `src/frontend-app/`, run `npm install` (or `npm update vite`), ensuring the resulting `package-lock.json` resolves to `vite@>=5.5.0` and the intended patched Rollup version.
- Commit the updated `src/frontend-app/package-lock.json`.

### Fix Focus Areas
- src/frontend-app/package-lock.json[1-40]
- src/frontend-app/package-lock.json[4401-4435]
- src/frontend-app/package-lock.json[4870-4903]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

"vite-plugin-css-injected-by-js": "^3.4.0"
}
}
Loading