fix(ci): publish release binaries again - #1760
Merged
Merged
Conversation
Releases are cut by release-please, which creates the tag and the GitHub release with the default GITHUB_TOKEN. Events produced by that token never trigger another workflow, so the goreleaser job — triggered by `push: tags` — stopped running entirely after release-please was introduced. That is why v0.15.2 through v0.16.2 shipped with no downloadable binaries. On the three occasions it did run (v0.15.0, v0.15.1) goreleaser failed anyway. Replace it with a matrix build using wangyoucao577/go-release-action, and call it directly from the release-please workflow so it no longer depends on a tag event firing. A `workflow_dispatch` trigger is kept to backfill binaries on releases that are already published, and `push: tags` still covers hand-pushed tags. Binaries are published for linux, darwin and windows on amd64/arm64, plus linux armv6 and armv7. Fixes #1738 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
fclairamb
force-pushed
the
fix/release-binaries
branch
from
August 9, 2026 15:08
2266167 to
93793ba
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #1738 — the last four releases (v0.15.2 → v0.16.2) shipped with no downloadable binaries.
Two compounding causes:
GITHUB_TOKEN. GitHub deliberately does not fire workflows for events produced by that token, sogoreleaser.yml'spush: tagstrigger has been dead ever since. There are only 3 goreleaser runs in the repo's entire history, the last one on 2026-01-11 forv0.15.1.GOTOOLCHAIN: autofix from fix(ci): build release binaries again by allowing Go toolchain download #1717 was never actually exercised, because of cause 1.Fix
Replace goreleaser with a matrix build using
wangyoucao577/go-release-action, and — the important part — call it from the release-please workflow directly instead of relying on a tag event that can never fire..github/workflows/release-artifacts.yml(new) — reusable matrix build. Triggers:workflow_call(from release-please),workflow_dispatch(to backfill already-published releases), andpush: tags(hand-pushed tags)..github/workflows/release-please.yml— exposesrelease_created/tag_nameand chains the build job when a release is cut..github/workflows/goreleaser.ymland.goreleaser.yaml— removed.README.md— the download link was a broken relative/releases; now points at the releases page and lists the available platforms.goversion: go.modkeeps the build toolchain trackinggo.mod, so it cannot drift out of sync the way it did before.Artifacts produced
Each archive contains the
ftpserverbinary plusLICENSEandREADME.md, and is published with a.sha256sum.Verification
actionlintpasses on both workflows.Follow-up
Once merged, the already-published releases can be backfilled with:
🤖 Generated with Claude Code