Skip to content

[MERGE BEFORE 09/28/23 RELEASE] Add link to document page #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfultz merged 2 commits into from
Sep 28, 2023
Merged

[MERGE BEFORE 09/28/23 RELEASE] Add link to document page #5931

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2c2172
add link, extension, size
Sep 28, 2023
505d07c
wrap icon in if
Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions fec/home/templates/home/document_page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,14 @@ <h1 class="heading__left">{% formatted_title self %}</h1>
<div class="heading__right">
<span class="t-sans">{{ self.display_date }}</span>
</div>
{% endspaceless %}
</div>
{% endspaceless %}
</div>
</header>
<p class="t-sans t-normal">

@rfultz rfultz Sep 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <p> and <i> will always be included, right? Even if there's no self.file_url, no self.extension, and/or no self.size?

<i class="icon icon--inline--right icon--inline--left i-document"></i>{% if self.file_url %}<a href="{{ self.file_url }}">{{ self.title}}</a>{% endif %}
{% if self.extension %} | ({{ self.extension }}){% endif %}
{% if self.size %} | ({{ self.size }}){% endif %}
Comment on lines +30 to +31

@rfultz rfultz Sep 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be included even if there's no self.file_url, right? Granted, it seems unlikely

</p>
<div class="main__content">
{% include 'partials/body-blocks.html' with blocks=self.body %}
</div>
Expand Down