Skip to content

Fixing and standardizing UNIQUE_CONSTRAINTS and PKs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpb-bah wants to merge 4 commits into
base: qat
Choose a base branch
from
Open

Fixing and standardizing UNIQUE_CONSTRAINTS and PKs #9

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb144ff
Fixing and standardizing unique_constraints and PKs
dpb-bah May 21, 2026
d03cfff
black
dpb-bah May 21, 2026
b2edeb2
Fixing UNIQU_CONSTRAINTS types
dpb-bah May 22, 2026
25aa061
Merge branch 'qat' into standardizing-pks-unique-constraints
dpb-bah May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion brus_backend_common/models/lakehouse_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ class LakeHouseModel(ABC):
CSV_NAME: str
FORMAT: LakeHouseModelFormat
PK: str
UNIQUE_CONSTRAINTS: List[(str,)]
# TODO: Add PK and unique constraint validations
UNIQUE_CONSTRAINTS: List[str | (str,)]
MIGRATION_HISTORY: List[str] # must be ordered by earliest to latest

# The schema/structure of the delta table as StructType with StructFields
Expand Down
6 changes: 3 additions & 3 deletions brus_backend_common/models/reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class DEFCGroup(CSVModel):
TABLE_NAME = "defc_mapping"
DESCRIPTION = "Internal CSV to dynamically group DEFCs together"
CSV_NAME = "DEFC_MAPPING.csv"
PK = "DEFC_CODE"
PK = "code"
UNIQUE_CONSTRAINTS = []
MIGRATION_HISTORY = []

Expand Down Expand Up @@ -70,7 +70,7 @@ class FONBronze(CSVModel):
DESCRIPTION = "Raw FON data pulled from Grants.gov"
CSV_NAME = "funding_opportunity.csv"
PK = "id"
UNIQUE_CONSTRAINTS = [""]
UNIQUE_CONSTRAINTS = ["number"]
MIGRATION_HISTORY = []

STRUCTURE = BaseSchema(
Expand All @@ -96,7 +96,7 @@ class FONGold(CSVModel):
DESCRIPTION = "Processed FON data from FONBronze"
CSV_NAME = "funding_opportunity.csv"
PK = "funding_opportunity_id"
UNIQUE_CONSTRAINTS = []
UNIQUE_CONSTRAINTS = ["funding_opportunity_number"]
MIGRATION_HISTORY = []

STRUCTURE = BaseSchema(
Expand Down
Loading