Skip to content

FDG-9226 Non-DAP GA4: Create Custom Events - Dataset Page - #2307

Merged
LaKeishaW merged 6 commits into
masterfrom
FDG-9226
Aug 11, 2026
Merged

FDG-9226 Non-DAP GA4: Create Custom Events - Dataset Page#2307
LaKeishaW merged 6 commits into
masterfrom
FDG-9226

Conversation

@ntsim99

@ntsim99 ntsim99 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket:

FDG-9226

The following are ALL required for the PR to be merged:

  • Provided testing instructions in JIRA ticket if applicable
  • Provided mocks or additional information in JIRA ticket if applicable
  • Verified cross-browser compatibility: Chrome, Safari, Firefox, Edge
  • Verified mobile/tablet/desktop/monitor responsiveness
  • Verified that this PR does not create any new accessibility issues (via Axe Chrome)
  • Verify all files are covered by at least 93% test coverage if applicable
  • Verify that dashes are used for any visible defaults of evergreen values if applicable
  • Check for code quality
    + Watch out for irrelevant changes
    + Take time to understand the logic and flow; be on guard for pitfalls
    + Look at handoff between components (esp. number of props)
    + Watch out for literals (vs. variables) for css specs if applicable

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Total Line Coverage: 93.48% ✅

@LaKeishaW LaKeishaW self-assigned this Aug 10, 2026
@ntsim99
ntsim99 marked this pull request as ready for review August 11, 2026 15:12

@LaKeishaW LaKeishaW left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked, tagged, and approved. Great work on this!

@LaKeishaW
LaKeishaW merged commit bcdc900 into master Aug 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants