DEV-15466: Replaced cURL command with PUT Request in es_configure.py - #4708
Merged
Conversation
james-at-kc
approved these changes
Jul 28, 2026
james-at-kc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. cURL construction was fully replaced by PUT request. Ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
In vulnerability finding f222, it was reported that ES_HOSTNAME (with embedded basic-auth) passed through the shell curl command line. DEV-15466 notes:
Technical Details:
Solution implemented:
urllib.parse.run_curl_cmdmethod to handle the PUT request using the Request library instead of a cURL command.NOTE: There is an assumption made here that this will continue working in production with this change, but this needs to be tested in an environment (not a local) to be certain.
Requirements for PR Merge:
Explain N/A in above checklist: