Conversation
Add /login route. Reuses auth code from del. Move the header to a seperate template and use nested templates. Add HTML and CSS for navbar. Adjust the to padding of body to account for the space the navbar uses.
felixphew
reviewed
May 12, 2019
Owner
felixphew
left a comment
felixphew
left a comment
There was a problem hiding this comment.
Generally looks good. I'm waiting on a discussion with Kathleen about how we want the bot to look; I know this is probably unnecessary but if there's a second emote with different colours I might use that for the history page.
Also, this is probably a good opportunity to move the logo image into its own file 😛
| "net/http" | ||
| "strconv" | ||
|
|
||
| _ "github.com/mattn/go-sqlite3" |
Owner
There was a problem hiding this comment.
D'oh! I didn't even notice this was out of order.
| } | ||
| } | ||
|
|
||
| func login(w http.ResponseWriter, r *http.Request) { |
Owner
There was a problem hiding this comment.
This is literally exactly what I wrote to implement the login button!
Owner
|
I think I'll break this up into two commits, so I can merge the minor changes now before tonight's show. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add /login route. Reuses auth code from del.
Move the header to a seperate template and use nested templates.
Add HTML and CSS for navbar.
Adjust the to padding of body to account for the space the navbar uses.