Skip to content

Typing fixes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schnellerhase wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Typing fixes #49

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc8bd95
Remove unused type ignores
schnellerhase Jul 3, 2026
c871487
Fix: missing import
schnellerhase Jul 4, 2026
c59925b
Fix: type deduction
schnellerhase Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ffcx_backends/cuda/jit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import cffi
import ffcx
import ffcx.codegeneration
import ffcx.naming
import numpy as np
import numpy.typing as npt
Expand Down Expand Up @@ -206,11 +207,12 @@ def compile_forms(
else:
cache_dir = Path(tempfile.mkdtemp())

scalar_type = p["scalar_type"]
assert isinstance(scalar_type, str)

try:
decl = (
UFC_HEADER_DECL.format(np.dtype(p["scalar_type"]).name) # type: ignore
+ UFC_INTEGRAL_DECL
+ UFC_FORM_DECL
UFC_HEADER_DECL.format(np.dtype(scalar_type).name) + UFC_INTEGRAL_DECL + UFC_FORM_DECL
)

form_template = "extern ufcx_form {name};\n"
Expand Down Expand Up @@ -301,9 +303,12 @@ def compile_expressions(
else:
cache_dir = Path(tempfile.mkdtemp())

scalar_type = p["scalar_type"]
assert isinstance(scalar_type, str)

try:
decl = (
UFC_HEADER_DECL.format(np.dtype(p["scalar_type"]).name) # type: ignore
UFC_HEADER_DECL.format(np.dtype(scalar_type).name)
+ UFC_INTEGRAL_DECL
+ UFC_FORM_DECL
+ UFC_EXPRESSION_DECL
Expand Down
Loading