This repository was archived by the owner on Apr 18, 2024. It is now read-only.
Update search tests to use count if total not provided in bundle#177
Open
gabcbrown wants to merge 1 commit into
Open
Update search tests to use count if total not provided in bundle#177gabcbrown wants to merge 1 commit into
gabcbrown wants to merge 1 commit into
Conversation
Author
|
@arscan let me know if there's anything else I can do to make this PR ready. I have a few other things I'd like to contribute too. |
Author
|
Hi @arscan, @jawalonoski, please let me know if this project is being actively maintained. I have been using Crucible extensively, and I think there's a lot of great work here! I am finding bugs in the plan_executor, especially around generating resources and R3<=>R4 differences, that I would like to help fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #140 , the total field of a bundle can be provided in search results but is not required. This PR updates the Search and Sprinkler Search test suites to use a count of the resources in the bundle if no total is provided, just as #159 updated the History test suites. It was also mentioned in the discussion of PR 159 that pagination is required to get an accurate count, but since the tests in question aren't querying large numbers of resources this is reasonably left to further implementation.