Closed
Conversation
anorth
approved these changes
Apr 8, 2022
Member
anorth
left a comment
anorth
left a comment
There was a problem hiding this comment.
[shakes fist] stealing my praise lines!
actors/runtime/src/runtime/fvm.rs
Outdated
| // it even could validate the caller. | ||
| if !rt.caller_validated { | ||
| fvm::vm::abort(ExitCode::SysErrIllegalActor as u32, Some("failed to validate caller")) | ||
| fvm::vm::abort(ExitCode::USR_UNSPECIFIED.value(), Some("failed to validate caller")) |
Member
There was a problem hiding this comment.
This should be the "user assertion failed" one
dignifiedquire
force-pushed
the
dig/syserror
branch
from
bc60094 to
d718b1d
Compare
Stebalien
reviewed
Apr 10, 2022
Member
|
So, I think the core issue we (I?) have is that we're using
But I believe dig's proposal in #197 will solve this. Basically:
|
Stebalien
approved these changes
Apr 10, 2022
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
LGTM for merge modulo the incorrect comments.
Member
|
Updated to released dependencies. |
Contributor
Author
|
lgtm (can’t approve my own pr) |
Member
|
I've stolen the blame lines back for @anorth now that we're ready to merge. |
Member
|
Will be merged in #191. |
snissn
pushed a commit
to snissn/builtin-actors
that referenced
this pull request
Apr 11, 2025
…_Updates_KB V14 fip updates kb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #191