lftp - update to version 4.9.3 and use of fink gnulib

[sth0]

In trying to install lftp on macOS 15.X found that the included gnulib had several multiple defined errors. Changed to link to the fink version of gnulib. Updated to latest version of lftp. Also see Issue #1200 and PR#1234.

Added gnulib patch from gnulib upstream, but probably unnecessary since now linking against fink gnulib which has (or soon will) that upstream patch.

The testing phase has 1 FAIL of retrieving an https file for failure to find root certificates on macOS. Will see if that can be fixed later, see issue #1239

Package passes validation and all ftp tests

[nieder]

This has the same failure I noticed in #1200 (10.14.5):

/bin/sh ../libtool --silent  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio -I/sw/include -I//sw/include  -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -MT LocalAccess.lo -MD -MP -MF .deps/LocalAccess.Tpo -c -o LocalAccess.lo LocalAccess.cc
In file included from LocalAccess.cc:26:
../lib/dirent.h:100:36: error: too few arguments provided to function-like macro invocation
               && DT_SOCK != DT_WHT);
                                   ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__config:930:13: note: macro 'static_assert' defined here
#    define static_assert(__b, __m) _Static_assert(__b, __m)
            ^
In file included from LocalAccess.cc:26:
../lib/dirent.h:88:1: error: C++ requires a type specifier for all declarations
static_assert (DT_UNKNOWN != DT_FIFO && DT_UNKNOWN != DT_CHR
^
2 errors generated.

2. Where exactly is the linkage to fink-gnulib? fink-gnulib installs into %p/share/gnulib (not %p/lib) and there are no binary bits in it as far as I'm aware. And if it is somehow a (Build)Depends, it's not listed in either BuildDepends: or Depends:.

3. Also, the tests were purposely disabled because they require net access. You can run them locally by uncommenting the make check command, but for publishing, they have to stay off.

4. This supports openssl300, so should move to that so we can drop another openssl110 dependee.

[sth0]

Hmm.

#1 I don't get that error. Different versions of Xcode?

/bin/sh ../libtool --silent  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio -I/opt/sw/include -I//opt/sw/include  -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -MT LocalAccess.lo -MD -MP -MF .deps/LocalAccess.Tpo -c -o LocalAccess.lo LocalAccess.cc
mv -f .deps/SSH_Access.Tpo .deps/SSH_Access.Plo

2. I thought I had solved it by adding the LDFLAGS="-L%p/lib" line. Obviously not.
3. Will turn the tests back off. Even with the tests on, the https test fails and that won't work. Maybe it needs a dependence on ca-certificates?
4. Will change to openssl 300, I wasn't sure if it used openssl110 or 300. I can't really remove openssl300 from my system with out a lot of work. The -recursive remove is disabled in fink.

[sth0]

Updated with removed testing since it requires network access to lftp.yar.ru and removed vestigial use of openssl 1.1.0 which is not needed since it uses openssl 3.0.0. Ready for merger?

[nieder]

@TheSin- this passes all tests for me but they'll be disabled in final checkin due to network access. OK to commit?

[sth0]

I believe I commented out the testing and should be good for merging.

[TheSin-]

I use this app a ton so I'll try to update and test it today so we can get it updated in the tree, thanks for the work on it.

[sth0]

It is a very full featured application. However, the author seems to have reduced development and support, the last update was in 2024, and the author has this comment on his web page: "Unfortunately, I'm busy at my current job and have little time to support lftp." http://lftp.yar.ru

It has had 25 years of excellent development and support which is a good record! Let me know if you find any problems.