Draft
Conversation
…ged as I have make the complier xcode
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for logging Apple StoreKit 2 transactions on iOS by adding a new LogAppleTransaction API, including a Swift bridge for native interaction and updated CMake configurations to support Swift compilation. Several issues were identified in the CMake configuration, including a regression for Windows builds, incorrect platform detection logic for tvOS, non-portable header inclusion, and reliance on Xcode-specific variables that break other generators like Ninja.
AustinBenoit
added
the
tests-requested: full
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @AustinBenoit on commit ec3cc5c
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
AustinBenoit
added
tests-requested: full
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
AustinBenoit
added
type: feature request
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
StoreKit2 support for Apple devices. Make the LogAppleTransaction a no-op for Android and iOS
Testing
Added in a new integration test and steps to manually test the transactions.
Performed the manual testing as describe:
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.