Skip to content

Change permissions for add labels workflow#42

Merged
fivetran-rishabhghosh merged 8 commits into
mainfrom
fivetran-sahilkhirwal-patch-1
Jul 3, 2026
Merged

Change permissions for add labels workflow#42
fivetran-rishabhghosh merged 8 commits into
mainfrom
fivetran-sahilkhirwal-patch-1

Conversation

@fivetran-sahilkhirwal

@fivetran-sahilkhirwal fivetran-sahilkhirwal commented Jul 3, 2026 •
edited by fivetran-rishabhghosh
Loading

Copy link
Copy Markdown
Contributor

Description of Change

Added pull request write permission to pull requests

Testing

Tested on the PR using pull_request instead of pull_request_target

Checklist

Some tips and links to help validate your PR:

  • Tested the connector with fivetran debug command.
  • Added/Updated example-specific README.md file, see the README template for the required structure and guidelines.
  • Followed Python Coding Standards, refer here

@fivetran-sahilkhirwal fivetran-sahilkhirwal requested a review from a team as a code owner July 3, 2026 08:17
Copilot AI review requested due to automatic review settings July 3, 2026 08:17
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions trigger for the “PR Metadata” workflow to run on pull_request events instead of pull_request_target, which affects how the workflow is authorized when acting on pull requests.

Changes:

  • Switched workflow trigger from pull_request_target to pull_request for PR open/sync/reopen events.

Comment thread .github/workflows/add-label.yml Outdated
fivetran-sahilkhirwal
fivetran-sahilkhirwal commented Jul 3, 2026
View reviewed changes
Comment thread .github/workflows/add-label.yml Outdated
fivetran-sahilkhirwal
fivetran-sahilkhirwal commented Jul 3, 2026
View reviewed changes
Comment thread .github/workflows/add-label.yml Outdated
Copilot AI review requested due to automatic review settings July 3, 2026 08:22
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/add-label.yml Outdated
Comment thread .github/workflows/add-label.yml Outdated
Copilot AI review requested due to automatic review settings July 3, 2026 08:25
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/add-label.yml
Copilot AI review requested due to automatic review settings July 3, 2026 08:27
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/add-label.yml
Comment thread .github/workflows/add-label.yml
Copilot AI review requested due to automatic review settings July 3, 2026 08:34
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/add-label.yml Outdated
@fivetran-sahilkhirwal fivetran-sahilkhirwal self-assigned this Jul 3, 2026
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/add-label.yml
Comment thread .github/workflows/add-label.yml
@fivetran-sahilkhirwal fivetran-sahilkhirwal changed the title Change trigger from pull_request_target to pull_request Change permissions for add labels workflow Jul 3, 2026
fivetran-JenasVimal
fivetran-JenasVimal approved these changes Jul 3, 2026
View reviewed changes

@fivetran-JenasVimal fivetran-JenasVimal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-JenasVimal fivetran-JenasVimal self-requested a review July 3, 2026 09:27
@fivetran-rishabhghosh fivetran-rishabhghosh merged commit 14a65b3 into main Jul 3, 2026
3 of 4 checks passed
@fivetran-rishabhghosh fivetran-rishabhghosh deleted the fivetran-sahilkhirwal-patch-1 branch July 3, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@fivetran-rishabhghosh fivetran-rishabhghosh fivetran-rishabhghosh approved these changes
@fivetran-JenasVimal fivetran-JenasVimal fivetran-JenasVimal approved these changes

Assignees

@fivetran-sahilkhirwal fivetran-sahilkhirwal

Labels

ai-assisted/no risk/low size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fivetran-sahilkhirwal @fivetran-rishabhghosh @fivetran-JenasVimal