Skip to content

bug/timestamp-case-tz-ntz#204

Merged
fivetran-catfritz merged 6 commits into
mainfrom
bug/timestamp-case-tz-ntz
Jun 18, 2026
Merged

bug/timestamp-case-tz-ntz#204
fivetran-catfritz merged 6 commits into
mainfrom
bug/timestamp-case-tz-ntz

Conversation

@fivetran-catfritz

@fivetran-catfritz fivetran-catfritz commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • v1.6.1

This PR addresses the following Issue/Feature(s):

  • GA-1027700

Summary of changes:

  • Fixes a Snowflake runtime error in netsuite2__transaction_details caused by a TIMESTAMP_TZ vs TIMESTAMP_NTZ type mismatch on vendor_create_date. The fix casts datecreated to dbt.type_timestamp() in stg_netsuite2__vendors, ensuring a consistent timezone-naive type regardless of how the source delivers the field.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-catfritz fivetran-catfritz self-assigned this Jun 18, 2026

@fivetran-savage fivetran-savage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one tiny suggestion before approval.

Comment thread CHANGELOG.md Outdated
Comment thread integration_tests/dbt_project.yml
Co-authored-by: Savage Fivetran <sarah.savage@fivetran.com>

@fivetran-savage fivetran-savage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fivetran-catfritz fivetran-catfritz added the docs:ready Triggers the docs generator workflow. label Jun 18, 2026
@fivetran-catfritz fivetran-catfritz merged commit 73b6b18 into main Jun 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants