Skip to content

bugfix/cast_non_numeric_as_null#35

Merged
fivetran-savage merged 2 commits into
mainfrom
bugfix/cast_non_numeric_as_null
Jun 26, 2026
Merged

bugfix/cast_non_numeric_as_null#35
fivetran-savage merged 2 commits into
mainfrom
bugfix/cast_non_numeric_as_null

Conversation

@fivetran-savage

Copy link
Copy Markdown
Contributor

PR Overview

Package version introduced in this PR:

  • 1.0.1

This PR addresses the following Issue/Feature(s):

Summary of changes:

  • Fixes a runtime error in stg_workday__worker_history where annual_currency_summary_primary_compensation_basis, annual_currency_summary_total_base_pay, and annual_currency_summary_total_salary_and_allowances failed to cast when the value was non-numeric.

Submission Checklist

  • Alignment meeting with the reviewer (if needed)
    • Timeline and validation requirements discussed
  • Provide validation details:
    • Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
    • Testing Instructions: Confirm the change addresses the issue(s)
    • Focus Areas: Complex logic or queries that need extra attention
  • Merge any relevant open PRs into this PR

Changelog

  • Draft changelog for PR
  • Final changelog for release review

@fivetran-savage fivetran-savage self-assigned this Jun 25, 2026
@fivetran-savage fivetran-savage added the docs:ready Triggers the docs generator workflow. label Jun 25, 2026

@fivetran-avinash fivetran-avinash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-savage fivetran-savage merged commit bf25022 into main Jun 26, 2026
9 checks passed
@fivetran-savage fivetran-savage deleted the bugfix/cast_non_numeric_as_null branch June 26, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:ready Triggers the docs generator workflow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants