[FEATURE] Add element_count to unexpected rows results#11882
[FEATURE] Add element_count to unexpected rows results#11882BALOGUN-DAVID wants to merge 1 commit into
Conversation
|
A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution: Individual Contributor License Agreement v1.0 Once you have signed the CLA, you can add a comment with the text Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error. Users missing a CLA: balogun-david |
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
|
@cla-bot check |
|
Hi @joshua-stauffer, here again 😀 Could you please take a look at this PR when you'red chanced lmk If everything looks good |
|
Is this PR still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙇 |
Closes #11045
Changes
table.row_countas a metric dependency forUnexpectedRowsExpectation.element_countinBASIC,SUMMARY, andCOMPLETEvalidation result payloads.element_countwhile preserving existingresult_formatbehavior.Tests
.\.venv\Scripts\python.exe -m pytest tests/expectations/core/test_unexpected_rows_expectation.py -v.\.venv\Scripts\python.exe -m invoke lint --no-ptyDescription of PR changes above includes a link to an existing GitHub issue: Unexpected_rows_expectation doesn't give element_count in the validation results #11045
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB], [MINORBUMP]
Code is linted - run
invoke lint(usesruff format+ruff check)Appropriate tests and docs have been updated