fix: prevent duplicate toast announcements - #1292
Open
wanxiankai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToastContainerroleas the single announcement sourceFixes #1291
Why
ToastContainerusedaria-live="polite"while each toast defaults torole="alert". Sincealertis itself a live region, this nested live-regionstructure caused NVDA to announce the same toast multiple times and announce it
again when it was removed.
Removing the container's live-region attributes avoids the duplicate
announcements without changing toast roles, custom role overrides, the
container's accessible label, or keyboard navigation.
Test plan
pnpm buildpnpm exec prettier --check src/components/ToastContainer.tsx src/tests.cy.tsxpnpm exec cypress run --component -b chrome --spec 'src/**/*.cy.tsx,packages/**/*.cy.tsx'(70 passing, 7 existing pending)role="alert"toast with noaria-liveancestor