Skip to content

feat: detect core type for AuthenticAMD - #1984

Open
mauri870 wants to merge 1 commit into
flightlessmango:masterfrom
mauri870:cpu-type-amd
Open

feat: detect core type for AuthenticAMD#1984
mauri870 wants to merge 1 commit into
flightlessmango:masterfrom
mauri870:cpu-type-amd

Conversation

@mauri870

@mauri870 mauri870 commented Mar 9, 2026

Copy link
Copy Markdown

Currently enabling the "Core Type" option in AMD cpus results in an "unknown" label for each core.

Implement detection of X3D cores and frequency cores by inspecting the cpu model name and L3 cache topology.

Fixes #1933


9950X3D shows:

image

Comment thread src/cpu.cpp Outdated
Comment thread src/cpu.cpp Outdated
Comment thread src/cpu.cpp Outdated
Comment thread src/cpu.cpp Outdated
Comment thread src/cpu.cpp
Comment thread src/cpu.cpp Outdated
Comment thread src/cpu.cpp Outdated
@mauri870

Copy link
Copy Markdown
Author

@flightlessmango Friendly ping for review

@flightlessmango

Copy link
Copy Markdown
Owner

Could you please clean up the commit history before we proceed? There are several intermediate commits that make it harder to review

@mauri870

mauri870 commented Mar 28, 2026

Copy link
Copy Markdown
Author

Could you please clean up the commit history before we proceed? There are several intermediate commits that make it harder to review

Sure, I've squashed everything into a single commit.

Also, with the newly announced 9950X3D2, I took another look at the logic. It should still work fine with dual X3D CCD CPUs.

@mauri870

mauri870 commented May 7, 2026

Copy link
Copy Markdown
Author

Friendly ping for review @flightlessmango

@mauri870

Copy link
Copy Markdown
Author

Hi @flightlessmango! Friendly ping on this PR.

This has been open since March, and I was wondering if anyone has had a chance to take a look. I'm happy to make any requested changes or rework the implementation if needed.

@flightlessmango

Copy link
Copy Markdown
Owner

This PR includes a merge commit from master dce4b95 in addition to the actual feature commit. Please clean up the branch history so the PR only contains the amd core-type change

Currently enabling the "Core Type" option in AMD cpus results in an
"unknown" label for each core.

Implement detection of X3D cores and frequency cores by inspecting
the cpu model name and L3 cache topology.
@mauri870

Copy link
Copy Markdown
Author

This PR includes a merge commit from master dce4b95 in addition to the actual feature commit. Please clean up the branch history so the PR only contains the amd core-type change

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CPU cores display as "unknown" on AMD Ryzen 7 5700X

3 participants