Fixes regarding hide_fps_superscript in horizontal mode and fps_metrics component. - #2022
Merged
Merged
Conversation
Contributor
Author
|
A test might be needed for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing new inconsistent behavior implemented during a rewrite e96a0bf
Which is, with
horizontalmode enabled and long names selected (lackingengine_short_namesin the config), fps superscript remains hidden (even without the use ofhide_fps_superscript) and engine name is replaced with an "FPS" text.This shouldn't happen when user prefers a long engine name to be present.
Additionally addressed issues provided by @ChrisLane discussed in pr #1821 related to a feature implemented in pr #1751.