Skip to content

Fixes regarding hide_fps_superscript in horizontal mode and fps_metrics component. - #2022

Merged
flightlessmango merged 1 commit into
flightlessmango:masterfrom
JustCryen:FPSstats
Apr 23, 2026
Merged

Fixes regarding hide_fps_superscript in horizontal mode and fps_metrics component.#2022
flightlessmango merged 1 commit into
flightlessmango:masterfrom
JustCryen:FPSstats

Conversation

@JustCryen

Copy link
Copy Markdown
Contributor

Fixing new inconsistent behavior implemented during a rewrite e96a0bf
Which is, with horizontal mode enabled and long names selected (lacking engine_short_names in the config), fps superscript remains hidden (even without the use of hide_fps_superscript) and engine name is replaced with an "FPS" text.
This shouldn't happen when user prefers a long engine name to be present.

Additionally addressed issues provided by @ChrisLane discussed in pr #1821 related to a feature implemented in pr #1751.

  1. FPS superscript still appears for FPS stats in the fps_metrics component.
  2. hide_engine_names does not override engine_short_names so if the latter appears in config, the former will not take effect.
  1. I figured out how to get the hide_fps_superscript to influence the superscript in the fps_metrics component. […]
  2. […] it seems like this point is already taken care of. hide_engine_names with or without engine_short_names does show just the big FPS text, and hides superscript in the main FPS meter in the process, but also disables the superscript in the fps_metrics component.
    Let me know how this should be handled.

@JustCryen

Copy link
Copy Markdown
Contributor Author

A test might be needed for the fps_metrics component, I'm not generally using it, so I had just a quick and dirty test conf file.
I might have missed something.

@flightlessmango
flightlessmango merged commit 330c42a into flightlessmango:master Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants