cpu: use hwmon reading if amdgpu reported CPU temp is 0 - #2095
Merged
flightlessmango merged 1 commit intoJul 24, 2026
Conversation
Right now, on my Strix Halo APU, my CPU temperature always reads as 0C even though k10temp is working and reporting Tctl and the amdgpu sensors output clearly shows no CPU temp value (just edge). I took a quick look at the amdgpu format 3 handling and it's iterating through all the sensors which are "VALID" but all reporting zero, so it preferes that value over the one reported by k10temp. My initial thought would be that we should prioritize the hwmon value for the CPU temp anyway, but this is the minimal change to continue prioritizing the amdgpu reported value and only fallback to hwmon if the reading is 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, on my Strix Halo APU, my CPU temperature always reads as 0C even though k10temp is working and reporting Tctl and the amdgpu sensors output clearly shows no CPU temp value (just edge).
I took a quick look at the amdgpu format 3 handling and it's iterating through all the sensors which are "VALID" but all reporting zero, so it preferes that value over the one reported by k10temp.
My initial thought would be that we should prioritize the hwmon value for the CPU temp anyway, but this is the minimal change to continue prioritizing the amdgpu reported value and only fallback to hwmon if the reading is 0.