-
Notifications
You must be signed in to change notification settings - Fork 23
Extract Avro class generation to avro-gen-ruby #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dorner
wants to merge
7
commits into
main
Choose a base branch
from
avro-gen-ruby
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c9ba690
Extract Avro class generation to avro-gen-ruby
dorner 1e8271f
Changelog, update comments and generated classes
dorner 711ef44
Remove deprecation
dorner cb394b1
Remove local override
dorner 770142b
Lint fixes
dorner ae5f3d1
Add avrogen schema namespace
dorner b7f93f1
Bump beta version
dorner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'avro_gen' | ||
|
|
||
| module Deimos | ||
| # Backwards-compatible shim. Schema class generation moved to the avro-gen-ruby | ||
| # gem (namespace AvroGen). Previously-generated classes that reference | ||
| # `Deimos::SchemaClass::Record` / `Enum` / `Base` still resolve here, with a | ||
| # one-time deprecation warning, via const_missing. | ||
| module SchemaClass | ||
| DEPRECATED_CONSTANTS = { | ||
| Base: AvroGen::SchemaClass::Base, | ||
| Record: AvroGen::SchemaClass::Record, | ||
| Enum: AvroGen::SchemaClass::Enum | ||
| }.freeze | ||
|
|
||
| # Maps the moved generation settings from Deimos.config.schema to AvroGen.config. | ||
| GENERATION_SETTINGS = { | ||
| generated_class_path: :generated_class_path, | ||
| nest_child_schemas: :nest_child_schemas, | ||
| use_full_namespace: :use_full_namespace, | ||
| schema_namespace_map: :schema_namespace_map | ||
| }.freeze | ||
|
|
||
| # @param name [Symbol] | ||
| def self.const_missing(name) | ||
| klass = DEPRECATED_CONSTANTS[name] | ||
| return super unless klass | ||
|
|
||
| Deimos::Logging.deprecate( | ||
| "Deimos::SchemaClass::#{name} is deprecated; use AvroGen::SchemaClass::#{name} instead. " \ | ||
| 'Run `rake avro:upgrade` to update generated classes.' | ||
| ) | ||
| # Define the constant so the warning is only emitted once. | ||
| const_set(name, klass) | ||
| klass | ||
| end | ||
|
|
||
| # Mirror the (now-delegated) Deimos schema settings onto AvroGen.config. | ||
| # Deimos.config.schema stays the source of truth within Deimos, so this runs | ||
| # on every configure (keeping a reset in sync). Standalone AvroGen users never | ||
| # trigger this and set AvroGen.config directly. | ||
| # @!visibility private | ||
| def self.sync_config! | ||
| schema = Deimos.config.schema | ||
| AvroGen.config.schema_path = schema.path | ||
| # Refresh AvroGen's cached schema stores on (re)configuration so they don't | ||
| # serve stale schemas after the schema path or files change. | ||
| AvroGen::SchemaValidator.clear_store_cache! | ||
|
|
||
| GENERATION_SETTINGS.each do |deimos_key, avro_key| | ||
| AvroGen.config.send("#{avro_key}=", schema.send(deimos_key)) | ||
| end | ||
| end | ||
| end | ||
| end |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.