Skip to content

Resolve #2868: Cover async rejection cleanup in raceWithAbort #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayden94 merged 1 commit into from
Aug 3, 2026
Merged

Resolve #2868: Cover async rejection cleanup in raceWithAbort #2897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/runtime/src/abort.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,23 @@ describe('raceWithAbort', () => {
await raceWithAbort(async () => 'ok', controller.signal);
expect(removeSpy).toHaveBeenCalledWith('abort', expect.any(Function));
});

it('removes the abort listener after fn rejects asynchronously', async () => {
const controller = new AbortController();
const addSpy = vi.spyOn(controller.signal, 'addEventListener');
const removeSpy = vi.spyOn(controller.signal, 'removeEventListener');
const originalError = new Error('async rejection');

const promise = raceWithAbort(async () => {
await Promise.resolve();
throw originalError;
}, controller.signal);

await expect(promise).rejects.toBe(originalError);
expect(addSpy).toHaveBeenCalledTimes(1);
const abortListener = addSpy.mock.calls[0]?.[1];
expect(removeSpy).toHaveBeenCalledWith('abort', abortListener);
});
});

describe('createAbortError', () => {
Expand All @@ -90,4 +107,4 @@ describe('createAbortError', () => {
expect(error.name).toBe('AbortError');
expect(error.message).toBe('Request aborted before response commit.');
});
});
});