Resolve #2873: Remove runtime test port reservation race - #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the reserve-close-rebind race from the runtime in-flight shutdown network test by letting the application bind an OS-assigned port directly.
Linked context: #2873
Closes #2873
Changes
port: 0instead of reserving and releasing a port first.NodeHttpApplicationAdapterafterlisten()and read the actual server address for the test request.finallyso assertion failures cannot leave shutdown waiting indefinitely.Testing
pnpm --filter @fluojs/runtime typecheck- passed.pnpm --filter @fluojs/runtime test- 29 files, 311 tests passed.git diff --check HEAD^..HEAD- passed.Release impact
No Changeset is required because this changes only test setup and cleanup; published runtime behavior, API surface, and package contents are unchanged.
Public export documentation
Behavioral contract
Platform consistency governance (SSOT)