ESCONF-43 Set ESlint React version setting to detect

[alb3rtino]

https://folio-org.atlassian.net/browse/ESCONF-43

The React version ESlint setting effects the rule behavior of plugins like eslint-plugin-react. Having it set to an older React version leads to missing or incorrect linting results. By setting it to detect, the current React version will be automatically detected, ensuring up-to-date linting.

[github-actions]

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit be848f3. ± Comparison against base commit b34e314.

♻️ This comment has been updated with latest results.

[github-actions]

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit be848f3. ± Comparison against base commit b34e314.

♻️ This comment has been updated with latest results.

[MikeTaylor]

Looks good, thanks for handling this!

[zburke]

This is obviously correct. Before you merge it, please try it out in a few different repositories to see how it affects things. If there are any changes, announce the pending PR on Slack#stripes-updates before you merge to avoid surprising people with unexpected changes.

Thank you for this fix!

[alb3rtino]

Changing the react version setting is a breaking change, as it alters the linting rules applied. Dependent projects may fail linting checks as a result.

[zburke]

@alb3rtino , I think this makes sense, but let's run it by @JohnC-80 when he is back next week.

See also folio-org/stripes-cli#349. Nobody has been pushing for that, but we could pull in this new version at the same time, allowing us to avoid a breaking change in stripes-cli later.