Skip to content

Fix renaming layers #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
madig wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix renaming layers #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/test_ufoLib2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,3 +284,17 @@ def test_convert_on_setattr(
assert not isinstance(obj, attr_type)
setattr(o, attr_name, obj)
assert isinstance(getattr(o, attr_name), attr_type)


def test_LayerSet_rename_layer(tmp_path: Path, datadir: Path) -> None:
ufo = ufoLib2.Font.open(datadir / "MutatorSansBoldCondensed.ufo")
ufo_tmp_path = tmp_path / "test.ufo"

# Make sure we are not in overwrite mode before renaming.
ufo.save(ufo_tmp_path)
ufo = ufoLib2.Font.open(ufo_tmp_path)
ufo.renameLayer("background", "public.background2")
ufo.save()

ufo2 = ufoLib2.Font.open(ufo_tmp_path)
assert ufo == ufo2