You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Awesome!
Not sure though about merging the production and dev Dockerfile. I think the Dockerfile is complex enough without it. And does it mean by doing docker build -t foodsoft . builds both the development and production image?
Also, when building the swagger file, I would expect it to have RAILS_ENV=production, e.g. routes might be affected by the environment.
thanks for your comments!
Hm yeah I see what you mean. I thought it could reduce complexity and I liked the multi-stage idea, but in the end everything blew up a bit.
You can choose what target to build with e.g. docker build --target development, but the production stage requires the development as it copies the swagger.yml file.
We could generate the swagger.yml in the production stage, but that would require the rswag gem in the prod group.
Good point about the RAILS_ENV, I think I used test as the rswag-specs gem is not part of the production group. Afaic the swagger file is generated by the definitions of the spec/requests/ tests. But I can double check if it makes any differences.
What a hack with the DATABASE_URL, I didn't know. I think I'd even prefer that than having another dependency ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR