Add home controller test#972
Merged
yksflip merged 5 commits intoMar 25, 2023
Merged
Conversation
yksflip
force-pushed
the
8_increase_test_coverage_controllers_home
branch
from
44583c3 to
26e5d0a
Compare
Member
|
At first glance, great! I can imagine this is useful especially for the Rails upgrade. 👍 |
Member
Author
|
thanks wvengen! |
Closed
10 tasks
Co-authored-by: viehlieb <pf@pragma-shift.net> Co-authored-by: Tobias Kneuker <tk@pragma-shift.net>
lentschi
reviewed
Mar 5, 2023
Contributor
lentschi
left a comment
lentschi
left a comment
There was a problem hiding this comment.
Looks fine to me in general; added some minor remarks
yksflip
force-pushed
the
8_increase_test_coverage_controllers_home
branch
2 times, most recently
from
3f28f81 to
4ee0f76
Compare
yksflip
force-pushed
the
8_increase_test_coverage_controllers_home
branch
from
4ee0f76 to
54e11dc
Compare
lentschi
requested changes
Mar 25, 2023
Member
|
Hooray! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: viehlieb pf@pragma-shift.net
Co-authored-by: Tobias Kneuker tk@pragma-shift.net