introduce importmaps#983
Merged
Merged
Conversation
This commit introduces importmaps. They allow to use modern javacript ESM within rails without webpack, yarn etc. see https://github.com/rails/importmap-rails for more details. Co-authored-by: Philipp Rothmann <philipprothmann@posteo.de> Co-authored-by: FGU <fgu@pragma-shift.net>
yksflip
force-pushed
the
9_rails_v_7_js_importmap_merge
branch
from
1834c39 to
51b5c10
Compare
Contributor
|
I think this would complete the Ruby/Rails update. Can we merge it? |
Member
Author
wvengen
approved these changes
Jun 14, 2023
Member
wvengen
left a comment
wvengen
left a comment
There was a problem hiding this comment.
Super!
(not sure why we include already minified jquery, since seems to be minification already, but that's another issue)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces importmaps. They allow to use modern javacript ESM within rails without webpack, yarn etc.
see https://github.com/rails/importmap-rails for more details.
This will be useful to add new features e.g. actiontext.
Depends on the rails upgrade #979
As it would require larger changes, we decided to keep the legacy javascript in it's old structure for now.