Prevent adding user to multiple order groups#993
Open
aban1 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution. Can you please remove the commits that contain comments as the only change? |
Author
|
Hello so sorry about that, I updated the pull request to only include
relevant changes.
Thank you!
…On Tue, Apr 11, 2023 at 2:49 AM kidhab ***@***.***> wrote:
Thanks for your contribution. Can you please remove the commits that
contain comments as the only change?
—
Reply to this email directly, view it on GitHub
<#993 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANRFKJCUQPKLQYKCN2BCAVTXAT5GPANCNFSM6AAAAAAWZTOIQY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
There are still two commits left that addresses other issues. Can you please remove them from this MR? |
Author
|
Again so sorry I forgot to switch branches before starting to work on a new task. I just removed those two from this PR. Thank you for your patience. |
Contributor
|
I just tested it. Your change prevents updating an existing ordergroup because the uniqueness check fails for existing ordergroup members. Can you try it on you instance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was aiming to resolve #967 of adding an error message for when someone tries to join multiple order groups.