Skip to content

Add ability to group delegated scope #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ballauriena wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ability to group delegated scope #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/scope_delegation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,14 @@ def delegate_scope(name, options)
source = options[:scope] || name
association = reflect_on_association(options[:to]) || raise("Unknown association")
name = [options[:prefix], name].compact.join("_")
grouping = options[:group]

scope name, Proc.new { |*args|
joins(association.name).merge(association.klass.send(source, *args))
if grouping
joins(association.name).merge(association.klass.send(source, *args)).group(grouping)
else
joins(association.name).merge(association.klass.send(source, *args))
end

@artfuldodger artfuldodger Nov 17, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do something like

relation = joins(association.name).merge(association.klass.send(source, *args))
relation = relation.group(grouping) if grouping
relation

to reduce the bit of duplication

@ballauriena ballauriena Nov 17, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried it and it broke things...i can dive in a little more next FF...and add specs :)

}
end
end