refactor(mirror): rename source types to ledgerV2Http / ledgerV2Database

[sylr]

What

Renames the two mirror source-type discriminators from http / postgres to ledgerV2Http / ledgerV2Database. The mirrorSource config stays a single object with one sub-property selecting the source type.

Supersedes the earlier multi-source (mirrorSources list) exploration on this branch — we decided not to implement several sources per mirror ledger for now. The history was rewritten to a single focused rename commit.

Why

http / postgres describe the transport, not what they connect to. ledgerV2Http / ledgerV2Database convey that both current sources read from a Ledger v2 system — via its HTTP API, or directly from its PostgreSQL database.

Scope

• Proto (common.proto): oneof field names http/postgres → ledger_v2_http/ledger_v2_database. Tag numbers (2/3) are preserved, so the change is wire-compatible with existing persisted data — only the field names (JSON keys + Go accessors) change.
• HTTP API: mirrorSource.type values → ledgerV2Http / ledgerV2Database (default ledgerV2Http).
• ledgerctl: --mirror-source-type values + completions + help.
• Operator CRD: spec.mirrorSource.ledgerV2Http / .ledgerV2Database sub-fields, plus a new CEL rule enforcing exactly one source type. Regenerated deepcopy + CRD YAML (config + helm, in sync).
• Docs + openapi updated.

The underlying message/struct type names (HttpMirrorSourceConfig, PostgresMirrorSource, …) are intentionally unchanged — they are internal identifiers that never appear in JSON/YAML.

Compatibility

Breaking rename of the API/CRD discriminator on pre-GA v1alpha1; existing mirror Ledger CRs / API bodies using http/postgres must switch to ledgerV2Http/ledgerV2Database. Persisted proto data is unaffected (tag numbers unchanged).

Verification

• Generated proto diff is minimal and canonical (commonpb only, no toolchain churn).
• Build green (main + operator); touched unit/integration suites pass: admission, HTTP handler, FSM create/promote, ledgerctl flags, operator controller; e2e mirror suite compiles.
• Report-only golangci-lint on the touched packages: 0 issues.

Note: the sandbox's proto/golangci toolchain drifted mid-session (a --fix tag-reorder + a golangci-lint linter-set change); those artifacts were kept out of this diff, which contains only the rename.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e7bc17dd-e6fa-4849-a3f9-9c44cfcc8b41

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/mirror-sources-list

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NumaryBot]

✅ Approve — automated review

The rename of source types to ledgerV2Http / ledgerV2Database is consistently applied across all layers: proto definitions, HTTP and CLI handling, operator CRD/controller paths, admission logic, tests, docs, and OpenAPI specs. No correctness issues were identified by any reviewer, all modified lines are covered by tests, and project coverage remains at an acceptable level. No actionable findings remain.

No findings.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.48%. Comparing base (20c929c) to head (ca1468e).
⚠️ Report is 7 commits behind head on release/v3.0.

Additional details and impacted files

@@               Coverage Diff                @@
##           release/v3.0    #1590      +/-   ##
================================================
- Coverage         75.00%   74.48%   -0.52%     
================================================
  Files               429      430       +1     
  Lines             44956    45722     +766     
================================================
+ Hits              33719    34057     +338     
- Misses             8297     8629     +332     
- Partials           2940     3036      +96     

Flag	Coverage Δ
e2e	74.48% <100.00%> (-0.52%)	⬇️
scenario	74.48% <100.00%> (-0.52%)	⬇️
unit	74.48% <100.00%> (-0.52%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[flemzord]

Reviewed at ca1468e6. The rename is otherwise consistently propagated through proto, HTTP input, CLI, operator CRDs, docs, and generated artifacts, and all targeted tests plus CI pass. One OpenAPI response-contract gap remains; details are inline.

[flemzord]

[P2] Split the request and response mirror-source schemas

This schema is also referenced by LedgerInfo, but that response is not encoded through mirrorSourceBody. LedgerInfo.MarshalJSON calls protoFieldJSON, so the renamed proto oneof serializes as {\"ledgerV2Http\":{...}} (or ledgerV2Database), not the flat {\"type\":\"ledgerV2Http\",...} declared here. Generated clients therefore still cannot model mirror-ledger responses from this contract. Please give LedgerInfo a oneof-shaped response schema, or normalize response serialization to the flat discriminator.