-
Notifications
You must be signed in to change notification settings - Fork 174
feat(ledgerctl): add --tls-server-name to verify by name while dialing by IP #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
dd5d89e
f71f411
602fe6e
50a0a9c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,7 @@ Use --use to activate it immediately even when other profiles already exist.`, | |
| cmd.Flags().String("server", "", "gRPC server address (required)") | ||
| cmd.Flags().Bool("insecure", false, "Use insecure connection (no TLS)") | ||
| cmd.Flags().String("tls-ca-cert", "", "Path to CA certificate file (PEM)") | ||
| cmd.Flags().String("tls-server-name", "", "Hostname to verify against the server certificate SANs, overriding the --server host") | ||
|
NumaryBot marked this conversation as resolved.
NumaryBot marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 [minor] LEDGERCTL_TLS_SERVER_NAME not applied when creating a profile via environment variable When Suggestion: Explicitly read
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Working as intended — declining this one. |
||
| cmd.Flags().String("signing-key", "", "Path to Ed25519 private key file for request signing") | ||
| cmd.Flags().String("signing-key-id", "", "Key ID for request signatures") | ||
| cmd.Flags().String("response-verify-key", "", "Path to Ed25519 seed file for verifying server response signatures") | ||
|
|
@@ -52,6 +53,7 @@ func runCreate(cmd *cobra.Command, args []string) error { | |
| server, _ := cmd.Flags().GetString("server") | ||
| insecure, _ := cmd.Flags().GetBool("insecure") | ||
| tlsCaCert, _ := cmd.Flags().GetString("tls-ca-cert") | ||
| tlsServerName, _ := cmd.Flags().GetString("tls-server-name") | ||
| signingKey, _ := cmd.Flags().GetString("signing-key") | ||
| signingKeyID, _ := cmd.Flags().GetString("signing-key-id") | ||
| responseVerifyKey, _ := cmd.Flags().GetString("response-verify-key") | ||
|
|
@@ -61,6 +63,7 @@ func runCreate(cmd *cobra.Command, args []string) error { | |
| Server: server, | ||
| Insecure: insecure, | ||
| TLSCaCert: tlsCaCert, | ||
| TLSServerName: tlsServerName, | ||
|
NumaryBot marked this conversation as resolved.
|
||
| SigningKey: signingKey, | ||
| SigningKeyID: signingKeyID, | ||
| ResponseVerifyKey: responseVerifyKey, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.