fix: namespace for dev envs#297
Conversation
WalkthroughThe Changes
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
Earthfile (1)
73-81: Release name is being passed as a flag – breaks Helm CLI parsing
helm upgrade --installalready expects the release name immediately after any flags.
Placing--install formance-operatorturnsformance-operatorinto an unexpected value for the--installboolean flag and the command fails at runtime.-RUN --no-cache helm upgrade --install --namespace formance-system --install formance-operator \ +RUN --no-cache helm upgrade --install formance-operator ./operator \ + --namespace formance-system \(The remaining flags can stay in any order after the chart path.)
Without this fix,
earthly +deploywill exit with:
Error: unknown flag: --install formance-operator.
🧹 Nitpick comments (1)
Earthfile (1)
93-95: Nice update – consider adding--create-namespacefor full idempotencyThe second Helm invocation now targets the new
formance-systemnamespace – good.
If someone skips the first operator chart (or runs the command stand-alone), this will fail unless the namespace already exists.- RUN --secret tld helm upgrade --install operator-configuration ./configuration \ - --namespace formance-system \ + RUN --secret tld helm upgrade --install operator-configuration ./configuration \ + --namespace formance-system \ + --create-namespace \Not critical but makes the step self-sufficient.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Earthfile(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: gfyrag
PR: formancehq/operator#292
File: Earthfile:67-70
Timestamp: 2025-06-27T06:57:35.884Z
Learning: In Earthfile, ADDITIONAL_ARGS variables can be reset between different helm commands using `SET ADDITIONAL_ARGS=""`. The pattern allows reusing the same variable name for different conditional arguments across multiple helm installations without causing duplication - first for formance-operator with imagePullSecrets, then reset and reused for operator-configuration with ghcrRegistry.
Earthfile (1)
Learnt from: gfyrag
PR: formancehq/operator#292
File: Earthfile:67-70
Timestamp: 2025-06-27T06:57:35.884Z
Learning: In Earthfile, ADDITIONAL_ARGS variables can be reset between different helm commands using `SET ADDITIONAL_ARGS=""`. The pattern allows reusing the same variable name for different conditional arguments across multiple helm installations without causing duplication - first for formance-operator with imagePullSecrets, then reset and reused for operator-configuration with ghcrRegistry.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Dirty
|
|
||
| ARG --required REPOSITORY= | ||
| RUN --no-cache helm upgrade --install --namespace formance --install formance-operator \ | ||
| RUN --no-cache helm upgrade --install --namespace formance-system --install formance-operator \ |
There was a problem hiding this comment.
It will break current deployment but that's ok
2 participants
No description provided.