feat: add Reasonix agent and edit diff previews#37
Open
yes999zc wants to merge 5 commits into
Open
Conversation
Reasonix (https://github.com/esengine/DeepSeek-Reasonix) is a DeepSeek-native coding agent with a cache-first loop architecture. It exposes `reasonix acp` as a stdio ACP entry point, matching the same pattern as Kiro CLI and Hermes Agent (direct binary invocation, not an npx package). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Before overwriting, read the old file content. After writing, open a vscode.diff editor comparing old (temp file) vs new content so users can review changes inline instead of just seeing the final state. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Many ACP agents (including Reasonix) write files directly via Node.js fs rather than calling the client's writeTextFile. This adds a DiffPreviewHandler that listens for session/update notifications, caches old file content when an edit-kind tool call starts, and opens a vscode.diff view when it completes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
yes999zc
changed the title
alanjds
pushed a commit
to alanjds/vscode-acp
that referenced
this pull request
Jun 30, 2026
Cherry-picked and adapted from formulahendry/vscode-acp: - fix(formulahendry#46): use correct Copilot package (@github/copilot@latest) - fix(#2): serialize concurrent permission requests to prevent silent cancellations when multiple QuickPick dialogs overlap - fix(formulahendry#6): respect acp.defaultWorkingDirectory in CWD resolution so workspace-scoped agents (kiro-cli etc.) find their config files - fix(formulahendry#13): add 30s AbortController timeout to registry fetch; make connect/newConversation/restart progress notifications cancellable - fix(formulahendry#47): redirect ACP pipe to fd 3 on login shells to prevent profile scripts (e.g. distrobox_profile.sh) from consuming fd 0 - feat(formulahendry#18): security hardening — workspace path validation in FileSystemHandler, env var filtering and shell:false in TerminalHandler - feat(formulahendry#42): editor context link — toggle to prepend active file/cursor info to chat prompts (acp.toggleEditorContext command) - feat(formulahendry#40): add Grok Build as pre-configured agent - feat(formulahendry#35): add openHarness as pre-configured agent - feat(formulahendry#44): add siGit Code as pre-configured agent - feat(formulahendry#37/agent): add Reasonix as pre-configured agent (diff preview implementation deferred to separate PR using formulahendry#43 approach) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pantelicmilan
pushed a commit
to pantelicmilan/CortexPipe
that referenced
this pull request
Jul 6, 2026
Implements real-time diff preview when ACP agents edit files, using VS Code's native diff editor with a custom URI scheme. Key changes: - DiffContentProvider: custom acp-diff: URI scheme (base64-encoded old content, no temp files) - DiffPreviewHandler: listens to session/update tool_call notifications, synchronously snapshots old content before edits, opens diff on completion - extension.ts: registers both providers with proper lifecycle management Architecture inspired by Cline's DiffViewProvider. Fixes race conditions and resource leaks from PR formulahendry#37 by using synchronous file reads and URI-based content storage. Co-Authored-By: Claude Code <noreply@anthropic.com> Co-Authored-By: Reasonix <noreply@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Reasonix as a pre-configured ACP agent and improves file-edit visibility for agents that edit files through their own tools.
Reasonix is a DeepSeek-native coding agent. It exposes
reasonix acpover stdio NDJSON JSON-RPC, matching the same direct-binary integration pattern as Kiro CLI and Hermes Agent.command = "reasonix"args = ["acp"]Why
Reasonix users currently have to configure the agent manually in
settings.json. A pre-configured entry makes it discoverable and reduces setup friction.While testing Reasonix through ACP, I also found that some agents write files directly through their own tooling instead of calling the client's
writeTextFilemethod. The client therefore needs to follow ACPtool_call/tool_call_updatenotifications to show the user which files are being edited and to open a final diff.Changes
Reasonixtoacp.agentsdefaults inpackage.jsonREADME.mdCHANGELOG.mdentry under UnreleasedDiffPreviewHandlerfor edit-kind tool callsparams.updatetoolCallIdstate across incrementaltool_call_updatepayloadslocations, diff content, raw tool input, and title fallbackValidation
reasonix acpspawns successfully via vscode-acptool_call/tool_call_updatenotifications from Reasonixnpm run compile-tests -- --pretty falsenpm run lintnpm run compileCompatibility
reasonixto be on PATH (brew install reasonixor install from GitHub Releases).🤖 Generated with Claude Code