fix: ignore Enter keydown during IME composition for CJK input#50
Open
123outsider wants to merge 1 commit into
Open
fix: ignore Enter keydown during IME composition for CJK input#50123outsider wants to merge 1 commit into
123outsider wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves chat prompt input handling in ChatWebviewProvider.ts by preventing Enter key actions from firing while the user is composing text via an IME (common for CJK input), avoiding accidental submits/cancels during composition.
Changes:
- Gate Enter-triggered actions behind
!e.isComposingto ignore Enter while IME composition is active. - Apply the same composition guard both for slash-command popup selection and for the main send/cancel Enter handler.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important improvement to the chat input handling in
ChatWebviewProvider.ts. It ensures that the Enter key only triggers actions when the user is not in the middle of composing text (such as when using an IME for non-Latin characters), preventing accidental submissions.!e.isComposing, so actions are not triggered while the user is composing text with an IME. (src/ui/ChatWebviewProvider.ts) [1] [2]