Skip to content

Add support for core lightning watchtower TEoS (The Eye of Satoshi) - server and client#543

Open
seberm wants to merge 20 commits into
fort-nix:masterfrom
seberm:feature/add-rust-teos
Open

Add support for core lightning watchtower TEoS (The Eye of Satoshi) - server and client#543
seberm wants to merge 20 commits into
fort-nix:masterfrom
seberm:feature/add-rust-teos

Conversation

@seberm
Copy link
Copy Markdown
Contributor

@seberm seberm commented Aug 30, 2022

@seberm seberm force-pushed the feature/add-rust-teos branch 16 times, most recently from 98f9500 to e0eae6d Compare September 3, 2022 20:39
@seberm seberm force-pushed the feature/add-rust-teos branch 3 times, most recently from bb319fe to 42626b6 Compare September 4, 2022 21:14
Comment thread pkgs/teos/default.nix Outdated
@seberm seberm force-pushed the feature/add-rust-teos branch 9 times, most recently from 93ad7ba to 509f3b8 Compare September 8, 2022 10:50
@seberm
Copy link
Copy Markdown
Contributor Author

seberm commented May 14, 2024

Any chance of getting this merged? I'll be glad for the review/comments and hints for improvement. Thanks! @erikarvstedt @jonasnick

@jonasnick
Copy link
Copy Markdown
Member

Thanks @seberm for your effort to keep this PR up to date!

I talked to Sergi, the main developer of teos, and he says that he isn't actively developing it but is planning to continue maintenance mode. He hasn't managed to make a new release so far and suggests to use master instead of the release.

So I don't think there is anything fundamental that's blocking this module as long as it is useful even in its current state. Needs review before it can get merged.

@seberm
Copy link
Copy Markdown
Contributor Author

seberm commented May 25, 2024

Hello @jonasnick,

He hasn't managed to make a new release so far and suggests to use master instead of the release.

The teos package is now part of nixkpgs upstream. I am not sure if we can use the master branch directly there.

However, if Sergi recommends using the master branch, I can prepare a package overlay at least for nix-bitcoin.

For anyone interested in getting this merged, please test it and feel free to provide a review. I'll be glad to address any issues.

Thanks!

Copy link
Copy Markdown
Contributor

@HaosGames HaosGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I started testing this now with CLN as a backend and the teos daemon on a separate host with a pruned bitcoind.
Works great so far with minimal configuration.

@HaosGames
Copy link
Copy Markdown
Contributor

Still running great on my side. I would love to see this in a release.

@sr-gi
Copy link
Copy Markdown

sr-gi commented Jul 29, 2024

I'm planning to cut a release sooner rather than later, which will include all the changes pointed out in the PR description AFAICT. Is there anything else that'd needed?

Copy link
Copy Markdown

@notjustanyusername notjustanyusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running the watchtower and plugin modules from this PR and its working well.

It would be nice to have a service that automatically registers with the tower and renews the subscription when needed. But we can add that later.

Also I opened a PR to add a flake to TEOS.

@seberm
Copy link
Copy Markdown
Contributor Author

seberm commented Dec 26, 2024

@nixbitcoin @erikarvstedt @jonasnick

Is it worthwhile to continue working on and rebasing this PR? Is there a possibility that nix-bitcoin will incorporate these changes?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CLN Watchtower

9 participants