Add support for core lightning watchtower TEoS (The Eye of Satoshi) - server and client#543
Add support for core lightning watchtower TEoS (The Eye of Satoshi) - server and client#543seberm wants to merge 20 commits into
Conversation
98f9500 to
e0eae6d
Compare
bb319fe to
42626b6
Compare
93ad7ba to
509f3b8
Compare
|
Any chance of getting this merged? I'll be glad for the review/comments and hints for improvement. Thanks! @erikarvstedt @jonasnick |
|
Thanks @seberm for your effort to keep this PR up to date! I talked to Sergi, the main developer of teos, and he says that he isn't actively developing it but is planning to continue maintenance mode. He hasn't managed to make a new release so far and suggests to use master instead of the release. So I don't think there is anything fundamental that's blocking this module as long as it is useful even in its current state. Needs review before it can get merged. |
|
Hello @jonasnick,
The However, if Sergi recommends using the master branch, I can prepare a package overlay at least for nix-bitcoin. For anyone interested in getting this merged, please test it and feel free to provide a review. I'll be glad to address any issues. Thanks! |
HaosGames
left a comment
There was a problem hiding this comment.
Looks good to me.
I started testing this now with CLN as a backend and the teos daemon on a separate host with a pruned bitcoind.
Works great so far with minimal configuration.
|
Still running great on my side. I would love to see this in a release. |
|
I'm planning to cut a release sooner rather than later, which will include all the changes pointed out in the PR description AFAICT. Is there anything else that'd needed? |
notjustanyusername
left a comment
There was a problem hiding this comment.
I'm running the watchtower and plugin modules from this PR and its working well.
It would be nice to have a service that automatically registers with the tower and renews the subscription when needed. But we can add that later.
Also I opened a PR to add a flake to TEOS.
# Conflicts: # modules/clightning-plugins/teos-watchtower-plugin.nix
|
@nixbitcoin @erikarvstedt @jonasnick Is it worthwhile to continue working on and rebasing this PR? Is there a possibility that nix-bitcoin will incorporate these changes? |
This MR adds basic support for rust-teos - package, module and clightning watchtower plugin.
Fixes: #540
TODO(s):