Open
Conversation
henilp105
commented
Jun 23, 2024
perazz
reviewed
Jun 24, 2024
perazz
reviewed
Jun 24, 2024
perazz
reviewed
Jun 24, 2024
Member
|
Let's get this merged @henilp105, is there any more tasks you plan of adding? |
Member
Author
|
Sure @perazz , Let's get this merged in a week, I will add some tests and clean UI by then. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new fpm search command that enables searching for packages in both local registries and the fpm-registry. Users can search using various filters including query text, package name, namespace, version, and license with support for globbing patterns.
- Adds comprehensive search functionality with multiple filter options and sorting capabilities
- Integrates search command into the existing fpm CLI structure with help documentation
- Updates downloader module to properly quote URLs in curl/wget commands
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/help_test/help_test.f90 | Adds 'search' command to help test suite |
| src/fpm_command_line.f90 | Implements search command line parsing, help text, and settings structure |
| src/fpm/downloader.f90 | Adds quotes around URLs in curl/wget commands for better URL handling |
| src/fpm/cmd/search.f90 | New module implementing the core search functionality for local and remote registries |
| app/main.f90 | Integrates search command into main application dispatcher |
Comments suppressed due to low confidence (1)
src/fpm_command_line.f90:1
- Typo in help text: 'fmp-registry' should be 'fpm-registry'.
!># Definition of the command line interface
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to add the search and discovery of fpm installed and fpm - registry packages directly from cli. this command supports globbing for package name, version, license, namespace. the similar functionality has been patched at the registry repo. (fortran-lang/registry#81). paging is not used in local registry due to multiple search queries.
This is the syntax of the new fpm search functionality:
Parameters:
Tasks left
Thanks and Regards,
Henil
CC @certik @awvwgk @perazz @arteevraina