Feature/wip filtering relationship#73
Merged
gr0uch merged 8 commits intofortunejs:masterfrom Jun 23, 2020
Merged
Conversation
Notes ----- Regarding integration into fortune.js I am unsure what field of request.options may be used. As I understand it, Adapter.find leaves the possibility of extra fields on the options object unspecified. Therefore, I added the fuzzyMatch on the ptions object. Regarding validity JSON:API Filtering is relatively unspecified. As such, I assume the extra filter type is legal.
gr0uch
requested changes
May 25, 2020
Member
gr0uch
left a comment
gr0uch
left a comment
There was a problem hiding this comment.
code looks fine, but can you run test please? I think you should also add a test case here to check that it will make the right request.
…eature/wip-filtering-relationship
- It relies on a unrelease version of fortune.js to make it run.
Contributor
Author
|
I think I covered all your comments. Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a try-out, I extend the fuzzy matching on relationship. The rest of the filters still need implementation.
Contrary to what I proposed in #60, I changed
filter[author.posts]tofilter[author:posts]. Ember.js (considered baseline use case) doesn't like parsing the former.So a call would be
/authors?filter[posts:title][fuzzy-match]=milkSee also #34 and #60 and fortunejs/fortune-postgres#35