[#4393] Inherit the item's base damage type for untyped activity damage#7099
Open
Sayshal wants to merge 1 commit into
Open
[#4393] Inherit the item's base damage type for untyped activity damage#7099Sayshal wants to merge 1 commit into
Sayshal wants to merge 1 commit into
Conversation
- Fall back to the host item's base damage type in _processDamagePart when a damage part specifies none - Gate the fallback on offersBaseDamage so it only applies to weapon and ammunition items - Leaves spell, healing, and utility damage untyped as before Closes foundryvtt#4393
Fyorl
added
system: activities
strategic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_processDamagePartwhen a damage part specifies noneoffersBaseDamageso it only applies to weapon and ammunition itemsCloses #4393