[#7109] Allow Check activities to configure one or more allowed abilities#7110
Open
thatlonelybugbear wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7109
Adds support for configuring multiple allowed abilities on Check activities, and uses that configuration to constrain skill/tool check roll dialogs opened from those activities.
Previously, a Check activity could configure associated skills/tools, but only one ability. The generated chat buttons used that configured/default ability, while the roll configuration dialog still allowed selecting any ability. This could make the activity appear to request a specific ability check while still allowing the final roll to be changed freely.
This PR changes Check activity
check.abilityto match the existing save activity pattern by storing it as aSetField, allowing one or more abilities to be selected.Included changes:
check.abilitystring data, converting it to the new array/set-compatible shape.Set<string>shape.