Skip to content

Add sync() methods to HybridCache for consistency guarantees #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Barre wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into main

db9d1c8
Select commit
Loading
Failed to load commit list.
Open

Add sync() methods to HybridCache for consistency guarantees #1090

Merge branch 'main' into main
db9d1c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 6, 2026 in 0s

55.11% (-27.90%) compared to e9f2c57

View this Pull Request on Codecov

55.11% (-27.90%) compared to e9f2c57

Details

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer/src/hybrid/cache.rs 0.00% 25 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e9f2c57) and HEAD (db9d1c8). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (e9f2c57) HEAD (db9d1c8)
3 1
Files with missing lines Coverage Δ
foyer/src/hybrid/cache.rs 44.04% <0.00%> (-39.30%) ⬇️

... and 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov