Skip to content

fix: Make HybridCache::is_hybrid() correctly return false when storage is not configured #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uckelman-sf wants to merge 2 commits into
base: main
Choose a base branch
from

fix: TypeId does not downcast, so Arc<dyn Engine>::type_id() cannot

739d678
Select commit
Loading
Failed to load commit list.
Open

fix: Make HybridCache::is_hybrid() correctly return false when storage is not configured #1283

fix: TypeId does not downcast, so Arc<dyn Engine>::type_id() cannot
739d678
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 11, 2026 in 1s

83.25% (+0.02%) compared to 481c3de

View this Pull Request on Codecov

83.25% (+0.02%) compared to 481c3de

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
foyer-storage/src/store.rs 86.43% <100.00%> (ø)
foyer/src/hybrid/cache.rs 85.23% <ø> (+0.48%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov