Skip to content

Allow award_emoji (reactions) API calls through PreToolUse hook #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JustTheWord wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow award_emoji (reactions) API calls through PreToolUse hook #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion coding-agent-plugins/claude-code/hooks/block-glab-api-discussions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ fi

REASON="Reading or writing MR discussions/notes via \`glab\` is blocked (matched: \`glab api .../discussions|notes\`, \`glab mr view --comments\`, or \`glab mr note\`). Use the \`glab-discussion\` CLI instead: \`glab-discussion read|write|diff|resolve|edit|delete\`. Run \`glab-discussion --help\` for usage, or load the \`glab-discussion\` skill."

if printf '%s' "$CMD" | grep -qE 'glab[[:space:]]+api\b.*merge_requests[^"'"'"']*/(discussions|notes)' \
# Award emoji (reactions) live under the notes URL path but are not discussion
# CRUD, and glab-discussion has no replacement command — let them through.
if { printf '%s' "$CMD" | grep -qE 'glab[[:space:]]+api\b.*merge_requests[^"'"'"']*/(discussions|notes)' \
&& ! printf '%s' "$CMD" | grep -qE 'glab[[:space:]]+api\b.*merge_requests[^"'"'"']*/award_emoji\b'; } \
|| printf '%s' "$CMD" | grep -qE 'glab[[:space:]]+mr[[:space:]]+view\b.*--comments\b' \
|| printf '%s' "$CMD" | grep -qE 'glab[[:space:]]+mr[[:space:]]+note\b'; then
jq -n --arg reason "$REASON" '{
Expand Down
6 changes: 6 additions & 0 deletions coding-agent-plugins/claude-code/hooks/test-block-glab-api-discussions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ run_case ALLOW 'glab mr create'
run_case ALLOW 'glab mr approve 42'
run_case ALLOW 'glab mr todo 42'

# ---------------- ALLOW: award emoji (reactions) under notes ----------------
run_case ALLOW 'glab api projects/123/merge_requests/5/notes/99/award_emoji -X POST -f name=recycle'
run_case ALLOW 'glab api "projects/:id/merge_requests/20/notes/1996757/award_emoji" -f name=thumbsup'
run_case ALLOW 'glab api projects/123/merge_requests/5/notes/99/award_emoji/7 -X DELETE'
run_case ALLOW 'glab api projects/mygroup%2Fmyrepo/merge_requests/42/award_emoji'

# ---------------- ALLOW: unrelated glab api calls ----------------
run_case ALLOW 'glab api projects/mygroup%2Fmyrepo/merge_requests/42'
run_case ALLOW 'glab api "projects/mygroup%2Fmyrepo"'
Expand Down