Skip to content

refactor: split set and validate warehouse functions

adbe9bc
Select commit
Loading
Failed to load commit list.
Draft

refactor: stock_entry file to improve readability and maintainability #54466

refactor: split set and validate warehouse functions
adbe9bc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 27, 2026 in 1s

79.45% (+0.17%) compared to 877d99c

View this Pull Request on Codecov

79.45% (+0.17%) compared to 877d99c

Details

Codecov Report

❌ Patch coverage is 84.98294% with 176 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.45%. Comparing base (877d99c) to head (adbe9bc).
⚠️ Report is 87 commits behind head on develop.

Files with missing lines Patch % Lines
...stock/doctype/stock_entry/manufacturing_handler.py 86.60% 120 Missing ⚠️
...k/doctype/stock_entry_detail/stock_entry_detail.py 78.16% 38 Missing ⚠️
erpnext/projects/doctype/project/project.py 10.00% 9 Missing ⚠️
erpnext/stock/doctype/stock_entry/stock_entry.py 88.46% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #54466      +/-   ##
===========================================
+ Coverage    79.28%   79.45%   +0.17%     
===========================================
  Files         1158     1161       +3     
  Lines       125604   126266     +662     
===========================================
+ Hits         99580   100321     +741     
+ Misses       26024    25945      -79     
Files with missing lines Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 86.90% <100.00%> (ø)
erpnext/manufacturing/doctype/job_card/job_card.py 69.41% <100.00%> (ø)
...anufacturing/doctype/work_order/test_work_order.py 98.52% <100.00%> (+<0.01%) ⬆️
...ext/manufacturing/doctype/work_order/work_order.py 82.55% <100.00%> (-0.15%) ⬇️
...next/stock/doctype/stock_entry/test_stock_entry.py 99.15% <100.00%> (ø)
...stock_reservation_entry/stock_reservation_entry.py 79.44% <100.00%> (-0.13%) ⬇️
...g_inward_order/test_subcontracting_inward_order.py 100.00% <100.00%> (ø)
erpnext/projects/doctype/project/project.py 53.68% <10.00%> (-1.33%) ⬇️
erpnext/stock/doctype/stock_entry/stock_entry.py 87.39% <88.46%> (+1.91%) ⬆️
...k/doctype/stock_entry_detail/stock_entry_detail.py 78.53% <78.16%> (-21.47%) ⬇️
... and 1 more

... and 67 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.