chore: remove ERPNext as parent icon

[sokumon]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

Nine desktop icon configuration files are updated with consistent modifications: the parent_icon field is removed from each file, and the modified timestamp is updated to a new value (all set to 2026-04-23 15:49:24 or 2026-04-23 15:49:25 with varying milliseconds). The files affected are assets, buying, crm, manufacturing, projects, quality, selling, stock, and support. No other fields are altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to evaluate relevance to the changeset.	Add a pull request description explaining the rationale for removing parent_icon fields and the impact of this change.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: removing ERPNext as parent icon across multiple desktop icon JSON files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@erpnext/desktop_icon/stock.json`:
- Line 17: Remove the parent_icon key from the stock.json entry (do not set it
to an empty string); delete the line with "parent_icon" entirely and
re-export/regenerate the desktop icon JSON so the modified timestamp matches the
other files (ensure stock.json is produced in the same export pass as the other
eight icon files).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 6c4e291e-3f03-4141-affa-f7eb5d2d8701

📥 Commits

Reviewing files that changed from the base of the PR and between b8c3765 and 4b8e30e.

📒 Files selected for processing (9)

• erpnext/desktop_icon/assets.json
• erpnext/desktop_icon/buying.json
• erpnext/desktop_icon/crm.json
• erpnext/desktop_icon/manufacturing.json
• erpnext/desktop_icon/projects.json
• erpnext/desktop_icon/quality.json
• erpnext/desktop_icon/selling.json
• erpnext/desktop_icon/stock.json
• erpnext/desktop_icon/support.json

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Inconsistent with PR intent: remove parent_icon entirely instead of setting it to "".

The other eight icon files in this PR drop the parent_icon key altogether, but here it is merely cleared to an empty string. Also, the modified timestamp (15:47:56.678195) is noticeably earlier than the rest (15:49:24/15:49:25), suggesting this file was not regenerated in the same pass. Please remove the field for consistency and re-export so timestamps align.

🔧 Proposed fix

  "owner": "Administrator",
- "parent_icon": "",
  "restrict_removal": 0,

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	"parent_icon": "",
	"owner": "Administrator",
	"restrict_removal": 0,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@erpnext/desktop_icon/stock.json` at line 17, Remove the parent_icon key from
the stock.json entry (do not set it to an empty string); delete the line with
"parent_icon" entirely and re-export/regenerate the desktop icon JSON so the
modified timestamp matches the other files (ensure stock.json is produced in the
same export pass as the other eight icon files).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.44%. Comparing base (7f8fa7c) to head (01732ab).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #54482   +/-   ##
========================================
  Coverage    79.44%   79.44%           
========================================
  Files         1160     1160           
  Lines       125984   126002   +18     
========================================
+ Hits        100083   100099   +16     
- Misses       25901    25903    +2     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.