chore: migrate to new docker publish workflow#54499
chore: migrate to new docker publish workflow#54499DanielRadlAMR wants to merge 1 commit intofrappe:developfrom
Conversation
📝 WalkthroughWalkthroughThe pull request modifies Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/docker-release.yml:
- Line 18: The curl call used to dispatch the workflow does not validate the
HTTP response so failures can be treated as success; update the curl invocation
(the curl POST that calls dispatches) to detect non-2xx responses and exit
non‑zero on failure by either adding --fail and --show-error or capturing the
HTTP status via -w "%{http_code}" and checking it, and log the response
body/error details to the job output to surface 401/404/422/5xx errors and
prevent silent success.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 944a25b1-984f-4a92-b20e-bd528046b6fc
📒 Files selected for processing (1)
.github/workflows/docker-release.yml
frappe/frappe#38966