Skip to content

fix(UX): Item master form cleanup (backport #54538)#54634

Open
mergify[bot] wants to merge 1 commit intoversion-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-54538
Open

fix(UX): Item master form cleanup (backport #54538)#54634
mergify[bot] wants to merge 1 commit intoversion-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-54538

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Apr 29, 2026

Issues with current form:

Screenshot 2026-04-27 at 12 00 13 PM
Screenshot 2026-04-27 at 12 18 47 PM
Screenshot 2026-04-27 at 12 30 41 PM
Screenshot 2026-04-27 at 12 48 06 PM
Screenshot 2026-04-27 at 12 31 48 PM
Screenshot 2026-04-27 at 12 38 09 PM
  • All field need tooltip for better understanding of the purpose.
Screenshot 2026-04-27 at 12 45 46 PM
  • Checkboxes need description/tooltip
Screenshot 2026-04-27 at 12 58 14 PM

After the refactor:

Screen.Recording.2026-04-28.at.5.25.19.PM.mov

More UX issue:

  • Saving an item with opening stock silently creates a stock entry without notifying the user.
Screen.Recording.2026-04-28.at.5.39.23.PM.mov
  • Saving an item with a Standard Selling Rate creates an Item Price record without any user notification.
Screen.Recording.2026-04-28.at.5.32.48.PM.mov

This is an automatic backport of pull request #54538 done by [Mergify](https://mergify.com).

* fix: UI improvements for item form

* fix: add descriptions and tooltips to all checkboxes

* feat: show toast notification when item price is created

* fix: do not use selling rate for opening stock entry

* fix: add descriptions and tooltips to item default fields

* fix(test): give valuation rate for opening stock entry creation

* fix: moving naming series toggle before the return

* refactor: more changes in the form UI

(cherry picked from commit 43937ac)
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.76%. Comparing base (64a724b) to head (0eb049c).
⚠️ Report is 46 commits behind head on version-16-hotfix.

Files with missing lines Patch % Lines
erpnext/stock/doctype/item/item.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-16-hotfix   #54634      +/-   ##
=====================================================
+ Coverage              79.46%   79.76%   +0.29%     
=====================================================
  Files                   1172     1172              
  Lines                 126286   126456     +170     
=====================================================
+ Hits                  100354   100862     +508     
+ Misses                 25932    25594     -338     
Files with missing lines Coverage Δ
...port/bom_stock_analysis/test_bom_stock_analysis.py 100.00% <ø> (ø)
erpnext/stock/doctype/item/item.py 84.22% <75.00%> (-0.21%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant